Skip to content

Please improve error handling for non-existent buckets #15

Open
@RodneyMarable

Description

@RodneyMarable

If I try to delete a stack with a non-existent bucket present in serverless.yml, serverless-s3-remover doesn't return an accurate error message:

$ aws s3 rb s3://test-bucket-rmarable --force
remove_bucket: test-bucket-rmarable

$ aws s3api head-bucket --bucket test-bucket-rmarable
An error occurred (404) when calling the HeadBucket operation: Not Found

$ sls remove
S3 Remover: Make test-bucket-rmarable empty. Are you sure? [yes/no]: yes
S3 Remover: Faild: test-bucket-rmarable may not be empty.

What should happen instead:

$ sls remove
S3 Remover: Make test-bucket-rmarable empty. Are you sure? [yes/no]: yes
S3 Remover: Faild: test-bucket-rmarable does not exist.

This issue was mentioned in #12 but doesn't seem to have been explicitly addressed.

Thanks for making this very useful plugin available.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions