switch to esmock, re #221 #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing |
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'clear-module' imported from /home/runner/work/update-notifier/update-notifier/test/fs-error.jsI'll resolve it in a moment |
|
its ready |
sindresorhus
requested changes
Jul 19, 2022
test/update-notifier.js
Outdated
| process.env.NO_UPDATE_NOTIFIER = '1'; | ||
| const notifier = updateNotifier(generateSettings()); | ||
| t.is(notifier.config, undefined); | ||
| }); | ||
|
|
||
| test('don\'t initialize configStore when --no-update-notifier is set', t => { | ||
| test('don\'t initialize configStore when --no-update-notifier is set', async t => { | ||
| const updateNotifier = await esmock('../index.js', null, {'is-ci': false}); |
There was a problem hiding this comment.
Suggested change
| const updateNotifier = await esmock('../index.js', null, {'is-ci': false}); | |
| const updateNotifier = await esmock('../index.js', undefined, {'is-ci': false}); |
There was a problem hiding this comment.
this added to the commit pushed below
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221
I hope the changes here are OK and wanted to mention two things. One thing, some tests, expected to fail, were passing in my local environment. I found this this recent commit which indicated to me that the passing tests might be OK -- not sure. The tests in question are found in test/notifier.js.
The other thing is, esmock-imported modules are each using their own state, so tests could be updated in the future to run concurrently rather than sequentially (here).