Add counter for multiple occurences

[CanRau]

Closes #37

That's actually what I already made for @gaiama/slugger

only issue so far is, it's not doing the by you preferred -2-2 😢

t.is(countableSlugify('foo-2'), 'foo-2-1'); // or foo-2-2

and I'm currently not sure how to properly do it without a rewrite.
I'm open to other implementations or preferences.

index.d.ts is probably not correct? Still very new to TS and external declarations.

Also I'm not sure if the used regex /(?:-\d+?)+?$/ is ReDoS safe or how much that matters here 🤷‍♂

[sindresorhus]

It cannot be the main slugify() method though as modifying it affects the whole process, not just your code. I'm thinking const countableSlugify = slugify.counter() to create a counter.

The counter cannot be global. It needs to create a new instance.

[CanRau]

Not sure I understand, the current implementation is used like so

const countableSlugify = slugify.counter();
t.is(countableSlugify('foo bar'), 'foo-bar');

[sindresorhus]

https://github.com/sindresorhus/slugify/pull/46/files#diff-168726dbe96b3ce427e7fedce31bb0bcR71 is global. If slugify is used in multiple places in the dependency tree, they will share this, which will cause really weird problems.

[CanRau]

You're right 😅
That should fix it, I've added tests for it as well.
Is that how you "envisioned" it?

[sindresorhus]

Yes, perfect. That's exactly what I had in mind.

[sindresorhus]

Can you add docs (readme + TypeScript file)? And also mention some use-cases in the docs.

[CanRau]

I updated everything as good as I could.
Please let me know if that works for you.

[CanRau]

Should the countableSlugify count empty strings like

countableSlugify(""); // => ""
countableSlugify(""); // => "-2"

or should it always return "" ? 🤔

[sindresorhus]

or should it always return "" ? 🤔

This. Add tests for that.

[sindresorhus]

Make sure $ npm test passes locally.

[CanRau]

Thanks for the reminder, I only ran npx ava --watch yesterday and forgot about xo & tsd 😬

[sindresorhus]

Looks great now. Thanks for working on this 👍

[CanRau]

Thanks a lot for your patience & guidance @sindresorhus very much appreciated 🙏
I learned a lot 🎉