Local binaries should have higher priority than global binaries #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
npm-run-pathmakes global binaries have higher priority than local binaries, which is incorrect.This bug was introduced by me in #8 (I am very sorry about this! :-/ ). The reason behind #8 was for
npm-run-pathto enforce that the current Node.js version is re-used in child processes, including when a user installsnodelocally (e.g. throughnpx node).However, as a side effect, #8 also inverted the priority between global binaries and local binaries since
nodeis installed in the same directory as binaries. This means ExecapreferLocaloption is no longer working (see sindresorhus/execa#404).This PR reverts to the old behavior.