-
-
Notifications
You must be signed in to change notification settings - Fork 960
Add more HTTPS tests #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more HTTPS tests #1430
Conversation
In order to do more deeper HTTPS tests it has been needed to replace https://github.com/lukechilds/create-test-server for those tests. The new This has also enabled me to remove external dependencies for testing the expired certificate and the wrong host (https://github.com/sindresorhus/got/pull/1430/files#diff-ef513147d9bbe98f3dc4e9dc04783109L123-R132). All that said I think this PR is ready for some review. |
Does the tests pass on Windows? |
Yes, I'm running it on Windows |
Some tests for the HTTPS options.
These tests simulate a real PKI application.
E.g. https://github.com/Giotino/got/blob/ca8d81314ac93bacd5e0c1da207210adf4e85a4a/test/https.ts#L232-L248
Types are messed up, I'm going to fix them soon, I'm also going to add support for
pfx
, needed for #1364.This is a draft, I'm going to add more tests covering more functionalities (e.g. key passphrase or invalid certificates).
create-cert-test-server.ts
is like https://github.com/lukechilds/create-test-server, but more specific for our needs.TODO List
Checklist