Print output with verbose option
#884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Mar 3, 2024
| // Also, we cannot use the real PID if we want to print it before `child_process.spawn()` is run. | ||
| // As a pro, it is shorter than a normal PID and never re-uses the same id. | ||
| // As a con, it cannot be used to send signals. | ||
| let VERBOSE_ID = 0n; |
There was a problem hiding this comment.
This is the number printed next to the timestamp.
ehmicky
commented
Mar 3, 2024
| // Files and streams can produce big outputs, which we don't want to print. | ||
| // We could print `stdio[3+]` but it often is redirected to files and streams, with the same issue. | ||
| // So we only print stdout and stderr. | ||
| const fdUsesVerbose = ([{fdNumber}]) => fdNumber === 1 || fdNumber === 2; |
There was a problem hiding this comment.
The comments in this file describe the reasons behind some of the restrictions for the verbose: 'full' option described in readme.md.
ehmicky
commented
Mar 3, 2024
| // They can also lead to double printing when passing file descriptor integers or `process.std*`. | ||
| // This only leaves with `pipe` and `overlapped`. | ||
| const shouldLogOutput = (stdioStreams, {encoding}, isSync, {verbose}) => verbose === 'full' | ||
| && !isSync |
There was a problem hiding this comment.
execaSync() cannot currently use this because it cannot use transforms and this feature uses transforms, for implementation reasons.
However, I am planning on adding support for both to execaSync() and will add an issue shortly.
|
Fixed merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #751.