Skip to content

Drop support for Node 14 #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 5, 2023
Merged

Drop support for Node 14 #569

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
41da329
Drop support for Node 14
ehmicky Jul 30, 2023
cde2670
Upgrade human-signals
ehmicky Jul 30, 2023
7910b0c
Upgrade c8
ehmicky Jul 30, 2023
9b652f1
Upgrade get-node
ehmicky Jul 30, 2023
5585dd3
Upgrade p-event
ehmicky Jul 30, 2023
ae21bb0
Upgrade tempfile
ehmicky Jul 30, 2023
1f50b50
Upgrade xo and tsd
ehmicky Jul 30, 2023
dc06c5f
Update package.json
sindresorhus Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ jobs:
fail-fast: false
matrix:
node-version:
- 20
- 18
- 16
- 14
os:
- ubuntu-latest
- macos-latest
Expand All @@ -25,6 +25,6 @@ jobs:
- run: npm install
- run: npm test
- uses: codecov/codecov-action@v2
if: matrix.os == 'ubuntu-latest' && matrix.node-version == 18
if: matrix.os == 'ubuntu-latest' && matrix.node-version == 20
with:
fail_ci_if_error: true
2 changes: 0 additions & 2 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,6 @@ export type CommonOptions<EncodingType> = {

When `AbortController.abort()` is called, [`.isCanceled`](https://github.com/sindresorhus/execa#iscanceled) becomes `false`.

*Requires Node.js 16 or later.*

@example
```
import {execa} from 'execa';
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"type": "module",
"exports": "./index.js",
"engines": {
"node": "^14.18.0 || ^16.14.0 || >=18.0.0"
"node": "^16.14.0 || >=18.0.0 || >=20.0.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure the exact version range you'd prefer. Please let me know, and I can update it.

},
"scripts": {
"test": "xo && c8 ava && tsd"
Expand Down Expand Up @@ -53,7 +53,7 @@
"strip-final-newline": "^3.0.0"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading signal-exit is not as straightforward because one of the tests relies on internals for that library, so I'll do it in a separate PR.

},
"devDependencies": {
"@types/node": "^18.13.0",
"@types/node": "^20.4.0",
"ava": "^5.2.0",
"c8": "^7.12.0",
"get-node": "^13.5.0",
Expand Down
2 changes: 0 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,8 +713,6 @@ You can abort the spawned process using [`AbortController`](https://developer.mo

When `AbortController.abort()` is called, [`.isCanceled`](#iscanceled) becomes `false`.

*Requires Node.js 16 or later.*

#### windowsVerbatimArguments

Type: `boolean`\
Expand Down