Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change after to next in badge rule #206

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hstsethi
Copy link

@hstsethi hstsethi commented Dec 28, 2024

I believe it is more clear. After implies beside.

I tried putting it after but it wouldn't stop throwing errors until the badge was placed next to it.

The guidelines also read:

Should be placed on the right side of the readme heading.

@hstsethi hstsethi closed this Dec 28, 2024
@hstsethi
Copy link
Author

hstsethi commented Dec 28, 2024

I have now changed test rules to accommodate for new error message, but this pull request will fail the checks until the updated rules are merged.

I can create another pull request if maintainers feel like the new error message is better.

@hstsethi hstsethi reopened this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant