Skip to content

[BUG] DriverType "Unknown" conflicts with EthernetLinkStatus in STM32Ethernet #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pascweb opened this issue Feb 18, 2025 · 2 comments
Assignees
Milestone

Comments

@pascweb
Copy link

pascweb commented Feb 18, 2025

Describe the bug
When using both the SimpleFOC and STM32Ethernet library in a project the definitions of DriverType and EthernetLinkStatus conflict as they both use Unknown in the definition.

Describe the hardware setup
Nucleo F429ZI with SimpleFOC shield v2

IDE you are using
Platformio

Suggested solution
Change "Unknown" to "UnknownDriver" in line 16 of FOCDriver.h and line 37 of CurrentSense.h

@runger1101001 runger1101001 self-assigned this Feb 18, 2025
@runger1101001 runger1101001 added this to the 2.3.5_Release milestone Feb 18, 2025
@runger1101001
Copy link
Member

Thanks for reporting it.

For the moment I have changed it in the way you have suggested. The real solution would be to use namespaces, but changing to use a namespace would be a big change requiring lots of documentation updates. So for the moment I think your approach is good. :-)

runger1101001 added a commit to runger1101001/Arduino-FOC that referenced this issue Feb 18, 2025
@runger1101001
Copy link
Member

I've made the change on the dev branch, so you could use that branch of the library to fix your problem for now. The change will be part of the next library release, version 2.3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants