Skip to content

MNT Run module-standardiser #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

emteknetnz
Copy link
Member

This pull-request was created automatically by module-standardiser

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either combine the if conditions or validate that both are executed and respected.

@emteknetnz emteknetnz force-pushed the pulls/master/module-standardiser-1743720292 branch from fa17f3f to 42d0c87 Compare April 7, 2025 03:50
@emteknetnz emteknetnz force-pushed the pulls/master/module-standardiser-1743720292 branch from 42d0c87 to 4a36c7f Compare April 7, 2025 03:56
@emteknetnz
Copy link
Member Author

Done

1 similar comment
@emteknetnz
Copy link
Member Author

Done

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit f083ede into silverstripe:master Apr 7, 2025
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/master/module-standardiser-1743720292 branch April 7, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants