Customize and add scripture-forge extension
#1
Conversation
…f merge conflicts
… messages, genericized license
…itting into its own repo as this problem will not be solved as long as the package used is local
- also add Volta node version
- also update other npm packages
…ry places as a temporary fix for TypeStrong/ts-node#1997
- `npm audit fix` - also ran `npx update-browserslist-db@latest`
…helpful instructions if there are no extensions to build
- also fix stylelint to work with tailwind @ directives
- Type checking doesn't happen at this level but within each contained extension. - use `noImplicitReturns` instead of `consistent-return` - improve types on error handling - also fix `micromatch` vulnerability using `npm audit fix` - also run `npx update-browserslist-db@latest`
- use the TS version of `class-methods-use-this` so we can ignore override methods.
- let prettier format CSS & SCSS - also `npm audit fix`
- `npm audit fix` - update minor and patch dependencies
git-subtree-dir: src/scripture-forge git-subtree-split: 8f243661b1ddc49a05f35774bc4da6a1d9edca28
There was a problem hiding this comment.
Thanks TJ!
Reviewed 42 of 42 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tjcouch-sil)
src/scripture-forge/assets/descriptions/description-en.md line 5 at r1 (raw file):
Allows you to view Slingshot drafts generated in Scripture Forge. TODO: Add description, features, limitations
Just curious, is this meant to be here?
src/scripture-forge/manifest.json line 11 at r1 (raw file):
"extensionDependencies": {}, "elevatedPrivileges": [], "types": "src/types/paranext-extension-template.d.ts",
Updated to scripture-forge.d.ts
tjcouch-sil
force-pushed
the
customize-and-add-extension
branch
from
28a198d to
c06c61e
Compare
There was a problem hiding this comment.
Thanks for the review!
Reviewable status: 41 of 42 files reviewed, 2 unresolved discussions (waiting on @jolierabideau)
src/scripture-forge/manifest.json line 11 at r1 (raw file):
Previously, jolierabideau wrote…
Updated to scripture-forge.d.ts
Good catch! Fixed :)
src/scripture-forge/assets/descriptions/description-en.md line 5 at r1 (raw file):
Previously, jolierabideau wrote…
Just curious, is this meant to be here?
Yep, I figure we can write this later. It's one of the checkboxes on the issue https://paratextstudio.atlassian.net/browse/PT-2192 :)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tjcouch-sil)
Just updated from templates, customized from multi-template, added
scripture-forgeextension, and customized it. Nothing meaningful added yet.This change is