Skip to content

don't use C# language preview for now #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Apr 3, 2025

closes #1570
workaround dotnet/efcore#35100 by not using language preview in lexbox for now.

This workaround will no longer be needed in EF Core 8.0.15 or 9.0.4 but those aren't out yet.

Copy link

coderabbitai bot commented Apr 3, 2025

📝 Walkthrough

Walkthrough

This pull request refactors the initialization of the Regex instance in the FwLiteEditionConfig class by introducing a private nullable field for lazy instantiation. Additionally, it removes the <LangVersion>preview</LangVersion> property from the project file and appends a newline after the closing tag in the .csproj file. The changes enhance code clarity without altering the overall logic.

Changes

File(s) Change Summary
backend/.../FwLiteReleaseConfig.cs Refactored the FdLiteEditionConfig class by introducing a private Regex? _fileName field and updating the FileName property for lazy initialization.
backend/.../LexBoxApi.csproj Removed the <LangVersion>preview</LangVersion> element from the property group and added a newline after the closing </Project> tag for proper formatting.

Assessment against linked issues

Objective Addressed Explanation
Fix "Add my Projects from org page fails" (#1570) Changes are limited to configuration refactoring and project file cleanup; no modifications related to project addition logic are evident.

Poem

I'm a coding rabbit with leaps so spry,
Tucking Regex in a field as time flies by,
Removing preview tags with a keen eye,
Hopping through code without a sigh,
Cheers for changes under the clear blue sky!
🐇 Keep on hopping, bugs goodbye!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0aa8192 and 51d3f9b.

📒 Files selected for processing (2)
  • backend/LexBoxApi/Config/FwLiteReleaseConfig.cs (1 hunks)
  • backend/LexBoxApi/LexBoxApi.csproj (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Build API / publish-api
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (csharp)
🔇 Additional comments (2)
backend/LexBoxApi/LexBoxApi.csproj (1)

67-68: Removed preview language version as per PR objectives

The removal of <LangVersion>preview</LangVersion> from the project file aligns with the PR's goal to stop using C# language preview features for now. This is a good temporary workaround for the Entity Framework Core issue mentioned in GitHub issue #35100.

The code will now use the default language version associated with the project's target framework instead of preview features.

backend/LexBoxApi/Config/FwLiteReleaseConfig.cs (1)

20-21: Refactored Regex initialization to avoid using language preview features

This change refactors the FileName property implementation to use standard C# features rather than requiring preview language features. By introducing a private nullable field _fileName and using the null-coalescing assignment operator (??=), the code maintains the same lazy initialization behavior without relying on preview features that may cause issues with Entity Framework Core.

The implementation is clean and follows best practices for lazy initialization in C#.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Apr 3, 2025

C# Unit Tests

107 tests  ±0   107 ✅ ±0   5s ⏱️ -1s
 16 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 51d3f9b. ± Comparison against base commit 0aa8192.

@hahn-kev hahn-kev merged commit a3d668c into develop Apr 4, 2025
11 checks passed
@hahn-kev hahn-kev deleted the dont-use-preview-language branch April 4, 2025 10:05
@coderabbitai coderabbitai bot mentioned this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add my Projects from org page fails
2 participants