Skip to content

[TreeView] Redesign UX for narrow windows #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 5, 2025
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented May 27, 2025

Resolves #3812


This change is Reviewable

Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.42%. Comparing base (266cb4f) to head (5c1c3fe).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../components/TreeView/TreeDepiction/ChildrenRow.tsx 83.33% 1 Missing ⚠️
src/components/TreeView/index.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3816      +/-   ##
==========================================
+ Coverage   73.34%   73.42%   +0.07%     
==========================================
  Files         286      287       +1     
  Lines       10750    10773      +23     
  Branches     1341     1344       +3     
==========================================
+ Hits         7885     7910      +25     
+ Misses       2471     2468       -3     
- Partials      394      395       +1     
Flag Coverage Δ
backend 82.91% <ø> (ø)
frontend 66.03% <94.59%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 3c0dd96 into master Jun 5, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the tree-view-narrow branch June 5, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TreeView] Design tree navigation for mobile users
2 participants