Fix bug in mocked inclusion proof #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian DeHamer <[email protected]>
🦋 Changeset detectedLatest commit: de5b7f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
feelepxyz
reviewed
Jul 28, 2023
| treeSize: treeSize, | ||
| checkpoint, | ||
| hashes: [leafHash.toString('hex')], | ||
| hashes: [], |
There was a problem hiding this comment.
Do you not need any hashes here?
There was a problem hiding this comment.
@feelepxyz as a result of fixing that verification bug we can now represent the simplest possible merkle tree which has a single node. In this scenario, the root hash of the tree is equal to the leaf hash of the sole node -- no other node hashes are required to verify the integrity of the tree.
feelepxyz
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in the inclusion proof returned as part of the mocked transaction log entry. The previous implementation was predicated on a bug that was recently discovered in the inclusion proof verification logic (see #646). With the verification bug fixed, we can need to adjust the fake inclusion proof generated for the mocked Rekor service.
Also took this opportunity to refactor the code in the mock
TLogclass to make SET and inclusion proof calculations more readable.