Skip to content

readme: Should the default example have "contents:write" ? #147

Open
@jku

Description

@jku

Now that the default is to upload release artifacts, I wonder if we should add contents: write to the main usage example in README?

  • The selftest does not need this permission I believe because the upload only triggers on release events
  • Could add the release trigger to the example as well since it's IMO the most magic in this action (I had never used GitHub release events for doing e.g. pypi releases so it was surprising to see it's required by this action)
  • if we're changing the example, could change the job name as well: "selftest" sounds a little weird in an example

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions