Skip to content

Fix Kurtosis doppelganger CI #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

chong-he
Copy link
Member

In recent Kurtosis update: kurtosis-tech/kurtosis#2689
kurtosis service add cannot take many arguments anymore, rather, we can pass the arguments in --json-service-config

This PR updates the doppelganger tests scripts to follow the new format

@chong-he chong-he added the ready-for-review The code is ready for review label Apr 22, 2025
@michaelsproul
Copy link
Member

Nice fix, thanks CK!

"cmd": [
"lighthouse",
"vc",
"--debug-level", "info",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting this changed to info. That's probably fine for CI, as we will usually debug locally if there are issues.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. infra-ci and removed ready-for-review The code is ready for review labels Apr 22, 2025
@mergify mergify bot merged commit 9f4b0cd into sigp:unstable Apr 22, 2025
31 checks passed
@chong-he chong-he deleted the fix-kurtosis-ci branch April 22, 2025 08:55
michaelsproul pushed a commit to michaelsproul/lighthouse that referenced this pull request Apr 29, 2025
Back-ported to release-v7.0.0 branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants