Skip to content

Address cargo audit failure RUSTSEC-2024-0437 #7114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

eserilev
Copy link
Member

@eserilev eserilev commented Mar 11, 2025

Issue Addressed

Resolves #7091

Proposed Changes

The prometheus crate pulls in protobuf 2.x which fails cargo audit. We actually dont use any protobuf related features in LH. By disabling default features for prometheus, we no longer pull in the protobuf crate

@eserilev eserilev added the ready-for-review The code is ready for review label Mar 11, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tasty! Nice fix!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 13, 2025
mergify bot added a commit that referenced this pull request Mar 13, 2025
@mergify mergify bot merged commit 3a555f5 into sigp:release-v7.0.0 Mar 13, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants