-
Notifications
You must be signed in to change notification settings - Fork 886
Pseudo finalization endpoint #7103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pseudo finalization endpoint #7103
Conversation
I've cherry-picked the split check fix from this PR: It would be awesome if we could add a unit test for manual finalization that shows it working correctly, and the node continuing to work after achieving real finalization. I think we could add such a test in |
Added a test that
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I will add one more test case using epochs_per_migration
to delay the split update, as I think that case is also interesting.
Regression test added and passing. Adding this to the queue. |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. If you want to requeue this pull request, you can post a |
Issue Addressed
This is a backport of:
holesky-rescue
#7071For:
Proposed Changes
Introduce a new lighthouse endpoint that allows a user to force a pseudo finalization. This migrates data to the freezer db and prunes sidechains which may help reduce disk space issues on non finalized networks like Holesky
We also ban peers that send us blocks that conflict with the manually finalized checkpoint.
There were some CI fixes in #7071 that I tried including here
Co-authored with: @jimmygchen @pawanjay176 @michaelsproul