-
Notifications
You must be signed in to change notification settings - Fork 886
feat: implement new beacon APIs(accessors for pending_deposits/pending_partial_withdrawals) #7006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at a glance, you're definitely on the right track. I've triggered CI so you can see if the tests pass. You can also run locally, just not in debug mode
You can fix the cargo format failure by running |
@michaelsproul Hi, thanks to #7007, I found that my test successfully passed with the commit. However, I'm afraid that default |
I think we should include this in v7.0.0 as we have some users asking about it. @syjn99 Do you mind rebasing your changes on the |
When you rebase, just take out all the commits from |
effa234
to
764e591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just pushed one small commit to use List
in the serialization rather than Vec
. This saves some copying of data (List
and Vec
have the same serialized representation anyway, so we can mix and match them).
Issue Addressed
Resolves #7003
Proposed Changes
Added two endpoints as ethereum/beacon-APIs#500 proposed:
/eth/v1/beacon/states/{state_id}/pending_deposits
/eth/v1/beacon/states/{state_id}/pending_partial_withdrawals