Skip to content

Update mergify conditions for trivial and ready-for-merge labels to satisfy if base is not stable #6997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

jimmygchen
Copy link
Member

Currently PRs only get merged if the base branch is unstable.
We could apply this condition to all branches except for stable, so that we don't have to manually queue the PRs.

I've changed the conditions to base!=stable, as we probably don't want auto approval or auto queue to stable.

@jimmygchen jimmygchen added ready-for-review The code is ready for review infra-ci labels Feb 13, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Checked against the config editor in the Mergify dashboard.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 13, 2025
@michaelsproul
Copy link
Member

I will merge this manually seeing as CI is failing.

@michaelsproul michaelsproul merged commit bf955c7 into sigp:stable Feb 13, 2025
25 of 29 checks passed
hzysvilla pushed a commit to ASSERT-KTH/lighthouse that referenced this pull request Mar 2, 2025
kamsz pushed a commit to ChorusOne/lighthouse that referenced this pull request Mar 17, 2025
Copy link

@char23-web char23-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

@jimmygchen jimmygchen deleted the update-mergify-config branch April 5, 2025 16:18
EllipticPoint pushed a commit to EllipticPoint/lighthouse that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra-ci ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants