Skip to content

chore: update peerDAS KZG library to 0.5.3 #6906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

kevaundray
Copy link
Contributor

Issue Addressed

This optimizes the time it takes to load the context, so that tests do not time out

@kevaundray kevaundray changed the base branch from stable to unstable February 3, 2025 13:41
Copy link

mergify bot commented Feb 3, 2025

This pull request has merge conflicts. Could you please resolve them @kevaundray? 🙏

@kevaundray kevaundray closed this Feb 3, 2025
@kevaundray kevaundray reopened this Feb 3, 2025
@kevaundray
Copy link
Contributor Author

Initially branched off of stable, which is why there are force pushes

@kevaundray
Copy link
Contributor Author

kevaundray commented Feb 3, 2025

Screenshot 2025-02-03 at 13 56 18

I get anywhere between 20-32% reduction, depending on the run. But the startup time is roughly the same at about 2.4-2.5 seconds.

To run these benchmarks:

  1. cd crypto/kzg
  2. cargo bench

@jxs jxs requested a review from michaelsproul February 3, 2025 14:15
@michaelsproul michaelsproul added ready-for-review The code is ready for review crypto An issue/PR that touches cryptography code. labels Feb 3, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! This does seem to have fixed the regression from 0.5.2!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 3, 2025
mergify bot added a commit that referenced this pull request Feb 4, 2025
@mergify mergify bot merged commit df131b2 into sigp:unstable Feb 4, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto An issue/PR that touches cryptography code. ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants