Add check to Lockbud CI job #6898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heres a failure example: |
eserilev
added
bug
jimmygchen
reviewed
Feb 3, 2025
| output=$(cargo lockbud -k deadlock -b -l tokio_util 2>&1) | ||
|
|
||
| # Check if lockbud returned any issues | ||
| if echo "$output" | grep -q '"bug_kind"'; then |
There was a problem hiding this comment.
Note: this may produce false negatives if cargo lockbud failed for other reasons e.g.
- compilation error
- lockbud internal issues
Although i think this is already better than before! Given that (1) compilation errors should fail other jobs as well, and we haven't seen (2) happened before (it may be very unlikely), I think we can go ahead and merge this.
There was a problem hiding this comment.
Agree.
This script was only intended to be a quick fix.
I do suggest we
- centralize this script as currently its copy pasta between anchor and LH.
- ultimately improve the lockbud cli so it can return and error code with the result.
jimmygchen
approved these changes
Feb 3, 2025
jimmygchen
added
ready-for-merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6637
Adds a script to check if Lockbud failed. Thanks @magick93 for working on this!