Update attestation rewards API for Electra #6819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
work-in-progress
|
Testing this is proving harder than I thought, but I should have something up tomorrow. |
michaelsproul
added
ready-for-review
dapplion
reviewed
Feb 4, 2025
michaelsproul
added a commit
that referenced
this pull request
Feb 7, 2025
Squashed commit of the following: commit 3539bcc Author: Michael Sproul <[email protected]> Date: Thu Feb 6 09:36:48 2025 +1100 Fix min balance in test commit ba4bfa7 Author: Michael Sproul <[email protected]> Date: Tue Feb 4 15:09:06 2025 +1100 Restore alternating credentials in beacon chain tests commit d2b0f54 Author: Michael Sproul <[email protected]> Date: Tue Feb 4 13:20:04 2025 +1100 Delete some junk commit 93c0301 Merge: 501280c 7e4b27c Author: Michael Sproul <[email protected]> Date: Tue Feb 4 09:57:20 2025 +1100 Merge branch 'unstable' into attestation-rewards-electra commit 501280c Merge: 252dbbd e4183f8 Author: Michael Sproul <[email protected]> Date: Fri Jan 31 16:39:56 2025 +1100 Merge remote-tracking branch 'origin/unstable' into attestation-rewards-electra commit 252dbbd Author: Michael Sproul <[email protected]> Date: Fri Jan 31 16:34:12 2025 +1100 Add regression test and generalise interop builder commit 2d8c308 Author: Michael Sproul <[email protected]> Date: Mon Jan 20 18:20:30 2025 +1100 Update attestation rewards API for Electra
dapplion
approved these changes
Feb 7, 2025
michaelsproul
added
ready-for-merge
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes:
Proposed Changes
Use
MAX_EFFECTIVE_BALANCE_ELECTRA(2048) for attestation reward calculations involving Electra.Add a new
InteropGenesisBuilderthat tries to provide a more flexible way to build genesis states. Unfortunately due to lifetime jank, it is quite unergonomic at present. We may want to refactor this builder in future to make it easier to use.Additional Info