-
Notifications
You must be signed in to change notification settings - Fork 886
Execution requests with prefix #6801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge to unstable!
Just re-running the local testnet jobs which I think failed due to the Github outage |
@mergify queue |
🛑 The pull request has been removed from the queue
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
@mergify requeue |
✅ This pull request will be re-embarked automaticallyThe followup |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 93f9c2c |
heck yeah |
Issue Addressed
Addresses ethereum/consensus-specs#3998 . Making a new PR because #6752 got closed
Proposed Changes
Make engine api alpha 10 spec compliant. Tested this on kurtosis with a geth client and confirms it works for single requests, gonna add tests for invalid requests in a separate PR in the spirit of getting devnet 5 ready asap.