Skip to content

Fix Sse client api #6685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Fix Sse client api #6685

merged 5 commits into from
Dec 18, 2024

Conversation

pawanjay176
Copy link
Member

@pawanjay176 pawanjay176 commented Dec 12, 2024

Issue Addressed

N/A

Proposed Changes

The get_events api in BeaconNodeHttpClient uses a regular http get request to stream the events. This doesn't handle a lot of sse params like return of partial bytes, maintaining a heartbeat etc. Using the get_events stream as an api consumer led to the connection getting repeatedly cutoff.
This PR uses reqwest_eventsource to do the sse handling.

Additional Info

Using reqwest-eventsource v0.5 to keep the reqwest version same as what we use in lighthouse.

@pawanjay176 pawanjay176 added the ready-for-review The code is ready for review label Dec 12, 2024
@pawanjay176
Copy link
Member Author

Tests seem to be failing, gonna try and fix it tomorrow

@michaelsproul michaelsproul added the v7.0.0-beta.0 New release c. Q1 2025 label Dec 13, 2024
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the tests are passing, so we're good to go.

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Dec 17, 2024
@michaelsproul
Copy link
Member

@mergify queue

Copy link

mergify bot commented Dec 17, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Dec 17, 2024
Copy link

mergify bot commented Dec 17, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@michaelsproul
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Dec 17, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Dec 17, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Dec 17, 2024
Copy link

mergify bot commented Dec 17, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@michaelsproul
Copy link
Member

@mergify requeue

Copy link

mergify bot commented Dec 17, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Dec 17, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Dec 17, 2024
Copy link

mergify bot commented Dec 17, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@pawanjay176
Copy link
Member Author

@mergify requeue

Copy link

mergify bot commented Dec 17, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

Copy link

mergify bot commented Dec 17, 2024

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Dec 17, 2024
Copy link

mergify bot commented Dec 17, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@pawanjay176
Copy link
Member Author

@Mergifyio requeue

Copy link

mergify bot commented Dec 17, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@pawanjay176
Copy link
Member Author

@Mergifyio queue

Copy link

mergify bot commented Dec 17, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #6685 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

Copy link

mergify bot commented Dec 17, 2024

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #6685 has been manually updated.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@pawanjay176
Copy link
Member Author

@Mergifyio queue

Copy link

mergify bot commented Dec 17, 2024

queue

🛑 The pull request has been removed from the queue default

The pull request #6685 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@pawanjay176
Copy link
Member Author

@Mergifyio refresh

Copy link

mergify bot commented Dec 17, 2024

refresh

✅ Pull request refreshed

@pawanjay176
Copy link
Member Author

@Mergifyio queue

Copy link

mergify bot commented Dec 17, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 2662dc7

@mergify mergify bot merged commit 2662dc7 into sigp:unstable Dec 18, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants