Skip to content

DEMRUM-2355 Update JSON encoding #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: feature/next-gen
Choose a base branch
from

Conversation

SMickelsn
Copy link
Contributor

  • Modified date formatting of timestamp
  • Added nested support for JSON encoding.

@SMickelsn SMickelsn requested review from a team as code owners June 6, 2025 01:55
Copy link

@carlosmcevilly carlosmcevilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@SMickelsn
Copy link
Contributor Author

I've made some large changes to the crash module.

  • Updated the send logic to send discrete attributes, rather than a string encoded body element, to more correctly mimic the existing crash reporting object.
  • Modified the code into several extensions to make it more readable.
  • Given the multiple attributes, I am using direct span logic as with other modules, rather than the existing publish
  • I have left the existing crash event logic in place in case it is prefered to modify it rather than the span logic currently in place.
  • Unit tests are not complete currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants