Fix issue #7279: set selected emoji color to be transparant; set sele… #7299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set selection color to be proper blue highlight color.
Comment on lines
+183
to
187
| .FunEmojiSelectionText::-moz-selection { | ||
| background-color: rgba(8, 73, 205, 255); | ||
| color: transparent; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think we need this. This ::-moz-selection is for Firefox and we only use Chromium inside of Signal Desktop.
| @@ -176,6 +176,14 @@ $inline-emoji-container-name: inline-emoji; | |||
| line-height: 64px; | |||
| user-select: text; | |||
| } | |||
| .FunEmojiSelectionText::selection { | |||
| background-color: rgba(8, 73, 205, 255); | |||
There was a problem hiding this comment.
We also may not need the background-color, I think it's only the color: transparent that is getting used to hide the text version of the emoji
|
Thank you for opening this, left a few comments if you want to try making those changes and seeing if it works alright |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ction color to be proper blue highlight color.
First time contributor checklist:
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
Fixes #7279
Simple manual testing
Before:
After:
Tested on Linux Mint (as where the issue was discovered)