Next / previous conversation keyboard shortcuts do not work in search results

[hiqua]

Bug (borderline feature) Description

Keyboard shortcuts to switch between conversations (Alt-down / Alt-up) do not work in search results.

Steps to Reproduce

1. search for conversations
2. obtain several results
3. try to use alt-down to cycle through the results

Actual Result:

Nothing happens.

Expected Result:

Cycling through the conversations, just like in the main view.

Platform Info

Signal Version:

5.0.0-beta3

Operating System:

Debian

[EvanHahn-Signal]

Thanks—I've filed this as a bug, and a good starter task.

This is happening because this method is unimplemented:

Signal-Desktop/ts/components/leftPane/LeftPaneSearchHelper.tsx

Lines 249 to 257 in 1c23efb

	// This is currently unimplemented. See DESKTOP-1170.
	// eslint-disable-next-line class-methods-use-this
	getConversationAndMessageInDirection(
	_toFind: Readonly<ToFindType>,
	_selectedConversationId: undefined | string,
	_selectedMessageId: unknown
	): undefined | { conversationId: string } {
	return undefined;
	}

If you work on this, a few things to keep in mind:

• Though it won't be the same, you can refer to how other left pane helpers do this. For example, you might want to follow the code in inbox helper.
• The current return type for the function is undefined | { conversationId: string }. I suspect it will change to undefined | { conversationId: string; messageId?: string }.
• Search results are in three groups: chats, contacts, and individual messages. Keep in mind that the currently selected row might not be in the same group if you move down. For example, if you've selected the final contact and press Alt-Down, the first message result will be selected.
• Make sure to add tests in LeftPaneSearchHelper_test.ts. I expect there will be several new tests (probably more than 2 but fewer than 10) for this behavior.
• Nothing should happen if any of the search results are loading.
• Comment here if you're going to take it on, just to make sure nobody else wastes their time.
• Let us know if you need help!

[jprask]

Hey guys, may I give this a try?

[hiqua]

@jprask sure!

[martineizayaga]

@jprask what's the status? Would you mind if I worked on this?

[jprask]

Thanks for checking @martineizayaga I'm writing the tests for it right now.

[abdullahnauman2]

Hi! I'd love to work on this task. Would that be okay?