-
Notifications
You must be signed in to change notification settings - Fork 3
Feat: update calico add compatibility to 1.29, release v1.17.0 #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nutellinoit
merged 11 commits into
main
from
feat/update-calico-add-compatibility-to-1.29
Apr 22, 2024
Merged
Feat: update calico add compatibility to 1.29, release v1.17.0 #79
nutellinoit
merged 11 commits into
main
from
feat/update-calico-add-compatibility-to-1.29
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralgozino
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If we are changing the supported versions, wouldn't it be better to bump the module's minor version? (i.e. 1.7.0 instead of 1.6.1)
- The compatibility matrix needs to be updated too.
- I left some non-blocking suggestions
Co-authored-by: Ramiro Algozino <[email protected]>
Co-authored-by: Ramiro Algozino <[email protected]>
I will do that |
ralgozino
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing update to the compatibility matrix
Done ✅ , merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for kubernetes 1.29 and bumps calico to 3.27.3 and tigera operator to 1.32.7
Also, I added e2e tests for tigera operator, that was missing.
I also made the tests sequential, since the parallel execution was breaking too many times.