-
Notifications
You must be signed in to change notification settings - Fork 101
feat(vue): support for showModal #1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d8b3ad1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5f4656a
to
57731d4
Compare
@tiagogviegas Thank for contribution great work there 👍! We are doing the review asap, we have to sync the recent activities regarding vue with your PR. |
@tiagogviegas With PR #1883 we moving our documentation to https://github.com/siemens/ix-docs. The PR contains some documentation changes, we have two options. Option 1: You rise a PR regarding the docu changes inside the new repo I would suggest Option 2, less work for you to keep the PRs up 2 date. Just give me a short answer |
@danielleroux Sure let's go with option 2. Thanks for review it 😄 |
Your changes are added to the new PR here: siemens/ix-docs#7 After the #1883 is merged you will get merge conflicts regarding |
I have tested it with the vue-test-app. I found that the vue test app behave different to the other test apps. by default:
It looks like the properties of the modal element are not being applied correctly. |
@danielleroux Fixed! Totally missed that. |
|
💡 What is the current behavior?
Showing an Modal on Vue differs from other frameworks and has no support for the
showModal
method.GitHub Issue: Fixes #1771
🆕 What is the new behavior?
showModal
to Vue🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm run docs
)pnpm test
)pnpm lint
)pnpm build
, changes pushed)👨💻 Help & support