Add geometry typecast test #1428
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testn
force-pushed
the
add-geo-typecast-test
branch
from
171ec96 to
63a4640
Compare
|
@sidorares any idea why geo stuff is broken in 5.7? I couldn't find any related release notes. |
|
don't know unfortunately, need to investigate |
|
@testn it fails at I can't see geometry types in https://dev.mysql.com/doc/refman/5.7/en/data-types.html We could check server version and skip the test if 5.7 or earlier, or somehow feature detect via sql |
|
CI logs from my copy of your commit - https://github.com/sidorares/node-mysql2/actions/runs/3906857317/jobs/6675468924 |
|
oh sure... let me do that |
testn
force-pushed
the
add-geo-typecast-test
branch
from
63a4640 to
9ba8992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add addition typecast tests for geometry