Skip to content

Fix compare to master files #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2017

Conversation

michaltk
Copy link
Contributor

Comparing with master files does not seem to be working bec:

  1. When checking if there are master files here, the destructed variable master is being used for this check. That variable was set before setting master on it. Fixed this by moving the destructing of files to after master was already set on it.
  2. In the setBuildStatus function, the name of the params of the function do not match the object that is being sent it. Fixed the names of it.

@siddharthkp
Copy link
Owner

@michaltk Hey!

Thanks for the pull request! I'll test this out tomorrow

Copy link
Contributor

@karanjthakkar karanjthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @michaltk good catch! Sorry about this! This was accidentally introduced in these commits: 568194d 9e4880be3acaa11fd88ef8f219252a3836f18460and has been there from v0.14.3 onwards.

@karanjthakkar
Copy link
Contributor

@SaraVieira Can we publish a new version whenever you are free? I'm not sure if this marks the test as failing in Github UI but in our store UI, the master column appears empty:

image

@SaraVieira
Copy link
Collaborator

I don't have access to publish the new UI on now , only @siddharthkp has :(

@karanjthakkar
Copy link
Contributor

@SaraVieira this is unrelated to the other PR. Here I'm talking about publishing a new version to npm with the fix. It doesnt need the store redeploy.

@SaraVieira
Copy link
Collaborator

@karanjthakkar I did one yesterday :)

@siddharthkp
Copy link
Owner

Hi! My spidey senses tingled. How can I help 😄

@karanjthakkar
Copy link
Contributor

karanjthakkar commented Oct 5, 2017

@SaraVieira Did you cherry pick the fix in this PR too? If not, we'll need to push another release with this fix.

@SaraVieira
Copy link
Collaborator

@karanjthakkar No I didn't , please push another release and I will publish it

@karanjthakkar karanjthakkar merged commit a511d4c into siddharthkp:master Oct 5, 2017
@karanjthakkar
Copy link
Contributor

@SaraVieira Done. Pushed v0.15.2

@SaraVieira
Copy link
Collaborator

@karanjthakkar Published 🎉

@karanjthakkar
Copy link
Contributor

Awesome!

Thanks again for bringing this to our attention and fixing this, @michaltk! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants