-
-
Notifications
You must be signed in to change notification settings - Fork 181
Fix compare to master files #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
so when checking for master it will be set
@michaltk Hey! Thanks for the pull request! I'll test this out tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @michaltk good catch! Sorry about this! This was accidentally introduced in these commits: 568194d 9e4880be3acaa11fd88ef8f219252a3836f18460and has been there from v0.14.3 onwards.
@SaraVieira Can we publish a new version whenever you are free? I'm not sure if this marks the test as failing in Github UI but in our store UI, the master column appears empty: |
I don't have access to publish the new UI on now , only @siddharthkp has :( |
@SaraVieira this is unrelated to the other PR. Here I'm talking about publishing a new version to npm with the fix. It doesnt need the store redeploy. |
@karanjthakkar I did one yesterday :) |
Hi! My spidey senses tingled. How can I help 😄 |
@SaraVieira Did you cherry pick the fix in this PR too? If not, we'll need to push another release with this fix. |
@karanjthakkar No I didn't , please push another release and I will publish it |
@SaraVieira Done. Pushed v0.15.2 |
@karanjthakkar Published 🎉 |
Awesome! Thanks again for bringing this to our attention and fixing this, @michaltk! 🥇 |
Comparing with master files does not seem to be working bec:
master
is being used for this check. That variable was set before setting master on it. Fixed this by moving the destructing offiles
to after master was already set on it.