-
Notifications
You must be signed in to change notification settings - Fork 8
✨ Add the option to specify the destination path #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution! The addition of an optional destination path is a great feature. I've made a couple of notes that I'd like for you to address before it's merged, but overall, I'm happy with the feature and look forward to merging it in :)
Additionally, we'll need to add this new input to the documentation:
- Add
destination
to theInputs
section in README.md - Remove "All inputs are required." and either add a new row to the table to indicate if an input is required, or make the input name bold and change the note to "All inputs in bold are required."
Please let me know if you need any help with these changes :)
Resolved all the requested changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for making the changes, everything looks great now :) I'll merge and release this later today, as version 2.1
(non-breaking new feature). Thanks again!
edit: I just need to modify the workflows to run on Pull Requests first.
No description provided.