Single-server servers.json from environment variables in Docker image #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Docker image, generate the servers.json with a single server by reading environment variables.
Preview environmenthttps://shlinkio.github.io/shlink-web-client/feature-server-from-env/ |
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 75.62% 75.62%
=======================================
Files 142 142
Lines 1670 1670
Branches 242 242
=======================================
Hits 1263 1263
Misses 213 213
Partials 194 194 Continue to review full report at Codecov.
|
|
Nice! I like the idea 🙂 I have just pushed a change renaming the env vars to be less redundant, becoming |
|
Awesome! :) Thanks for updating the docs, too! |
matiasgarciaisaia
added a commit
to matiasgarciaisaia/shlink-web-client
that referenced
this pull request
May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Docker image, generate the
servers.jsonfile with a single server by reading environment variables.This is useful to avoid mounts in hosted Docker environments.