Remove wmi for Get physical CPU core count #1839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lomanic
changed the title
Lomanic
requested changes
Apr 16, 2025
There was a problem hiding this comment.
Awesome work, thanks a lot @OrbintSoft. Tested on my windows 10 laptop, compared to psutil.cpu_counts(logical=False) and everything is fine.
Besides my other remarks, would you also mind squashing your commits?
|
for the commits you can do a squash and merge once you approve. |
shirou
reviewed
Apr 17, 2025
|
LGTM besides my last nit in https://github.com/shirou/gopsutil/pull/1839/files#r2047042897, but it's kind of personal preference, so can be merged at will. Thanks again @OrbintSoft 🙏 |
|
Can we merge or do you need other changes? |
shirou
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplemented get physical core count with windows api, so we can get rid of wmi.