Skip to content

[chore]: bump golangci-lint to v2.1.1 #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Mar 29, 2025

Description

This updates golangci-lint version to v2 and golangci-lint-action to V7.

@mmorel-35 mmorel-35 marked this pull request as ready for review March 29, 2025 08:55
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 5 times, most recently from df88209 to d0367a3 Compare March 30, 2025 10:06
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 8 times, most recently from 9468c0f to 97369d7 Compare April 6, 2025 07:07
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 4 times, most recently from 05a55b0 to 9aa7e72 Compare April 6, 2025 07:20
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 2 times, most recently from d1f9717 to 20e1b7e Compare April 6, 2025 07:22
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 5 times, most recently from d1c2e30 to 0a6cd6f Compare April 15, 2025 05:17
@mmorel-35 mmorel-35 changed the title [lint]: update golangci-lint action to v7.0.0 and refine linter settings [chore]: bump golangci-lint to v2.1.1 Apr 15, 2025
@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 2 times, most recently from d2f8091 to b75264c Compare April 15, 2025 05:21
@shirou shirou requested a review from Copilot April 15, 2025 08:31
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/lint.yml:72

  • Ensure that the commit hash matches the intended v7.0.0 release and verify that any breaking changes from the previous version are fully accounted for.
uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd  # v7.0.0

.golangci.yml:113

  • Verify that the newly added exclusion presets do not inadvertently suppress important warnings or critical issues.
exclusions:
    generated: lax
    presets:
      - comments
      - common-false-positives
      - legacy
      - std-error-handling

Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven’t been following all the changes in the configuration file syntax of the golangci-lint, but based on your previous contributions, I’m confident this PR will work just as well. Thank you very much!

@shirou shirou merged commit 7d9af6f into shirou:master Apr 17, 2025
52 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint@v2 branch April 17, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants