add support for get disk serial number on darwin #1791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shirou
requested changes
Feb 20, 2025
samburba
force-pushed
the
support-get-disk-serial-number-darwin
branch
3 times, most recently
from
409e7d2 to
b83bf7f
Compare
samburba
force-pushed
the
support-get-disk-serial-number-darwin
branch
from
b83bf7f to
9fc28f2
Compare
|
@shirou thanks for the review! I think I've made all the request changes. Let me know if there is anything I missed! |
|
@samburba Thank you for the update. However, there are still lint errors remaining, so I apologize for the trouble, but could you please fix them? Once that's done, I can merge it. |
shirou
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This is my first PR on this project, so let me know if I got anything wrong and should change it.
This fixes #801 and adds support for getting (NVMe) drives' serial number. It does this by executing system_profiler and unmarshalling.