Skip to content

chore: enable golangci-lint on Windows and MacOS #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 30, 2025

Description

Following #1784 (comment)

I have deliberately added '//nolint:... //FIXME' to make them easily to spot and fix

@mmorel-35 mmorel-35 force-pushed the golangci-lint-os-matrix branch from 83737c5 to 9ce2ec1 Compare January 30, 2025 19:10
@mmorel-35 mmorel-35 marked this pull request as ready for review January 30, 2025 19:13
Copy link

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much changes and fixes from a single comment that let us discover golangci-lint was not analysising code out of its compilation architecture

Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. Thank you so much for fixing many previously overlooked lint issues!

@shirou shirou merged commit 9438504 into shirou:master Feb 20, 2025
25 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint-os-matrix branch February 20, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants