chore: enable unused-parameter from revive #1783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
revive/unused-parameter
branch
from
0f0c11c to
d41f983
Compare
github-actions
bot
added
package:host
package:process
package:disk
package:docker
package:net
labels
mmorel-35
force-pushed
the
revive/unused-parameter
branch
2 times, most recently
from
ccce57b to
f672dca
Compare
mmorel-35
force-pushed
the
revive/unused-parameter
branch
2 times, most recently
from
2689660 to
053af0b
Compare
mmorel-35
force-pushed
the
revive/unused-parameter
branch
3 times, most recently
from
c4715fe to
051a2fe
Compare
|
@shirou , |
|
I have opened #1797 , I believe it's better to merge it first and then update this one. |
mmorel-35
force-pushed
the
revive/unused-parameter
branch
8 times, most recently
from
ca659f4 to
35e8062
Compare
mmorel-35
force-pushed
the
revive/unused-parameter
branch
from
35e8062 to
37dd0eb
Compare
mmorel-35
force-pushed
the
revive/unused-parameter
branch
5 times, most recently
from
103801b to
1f43ea8
Compare
|
@shirou, |
mmorel-35
force-pushed
the
revive/unused-parameter
branch
7 times, most recently
from
9bfd195 to
86eaf27
Compare
|
@shirou, |
|
Your contribution is greatly appreciated. However, there have been many updates, and I am struggling to keep up with the review process. I apologize for the delay, and I kindly ask for your patience. |
There was a problem hiding this comment.
Pull Request Overview
This PR enables the revive lint rule “unused-parameter” by updating several function signatures to replace unused parameters with an underscore.
- Updated functions across docker, disk, and cpu packages consistently mark unused parameters.
- Adjusted test functions and configuration files to support the new rule.
Reviewed Changes
Copilot reviewed 68 out of 68 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docker/docker_notlinux.go | Unused context parameters marked as "_" |
| disk/disk_solaris.go | Unused context and string parameters renamed |
| disk/disk_freebsd.go | Updated unused context parameters |
| cpu/cpu_solaris.go | Renamed unused context parameters |
| cpu/cpu_freebsd.go | Unused context parameters renamed (multiple functions) |
| cpu/cpu_openbsd.go | Updated unused context and logical parameters |
| cpu/cpu_dragonfly.go | Replaced unused parameters with "_" |
| cpu/cpu_darwin.go | Unused parameters updated appropriately |
| disk/disk_darwin.go | Replaced unused parameters with "_" |
| cpu/cpu_netbsd.go | Updated unused parameters for context and logical flag |
| docker/docker_linux_test.go | Marked testing parameters as unused |
| cpu/cpu_plan9.go | Renamed unused "percpu" parameter where applicable |
| cpu/cpu_windows.go | Unused context parameter renamed |
| disk/disk_openbsd.go | Updated unused parameters for disk functions |
| docker/main_test.go | Updated testing parameters to "_" |
| disk/disk_windows.go | Adjusted unused parameters in disk functions |
| disk/disk_netbsd.go | Replaced unused parameters with "_" |
| disk/disk_fallback.go | Updated unused context and other parameters appropriately |
| disk/disk_unix.go | Updated unused context parameter in UsageWithContext |
| .golangci.yml | Re-enabled the "unused-parameter" linter rule |
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
revive/unused-parameter
branch
from
86eaf27 to
dc9b409
Compare
shirou
reviewed
Mar 23, 2025
| @@ -6,7 +6,7 @@ import ( | |||
| "testing" | |||
| ) | |||
|
|
|||
| func TestSysAdvancedDockerInfo(t *testing.T) { | |||
| func TestSysAdvancedDockerInfo(_ *testing.T) { | |||
There was a problem hiding this comment.
The t should be used for test. I will make a PR in another PR.
shirou
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unused-parameter: This rule warns on unused parameters. Functions or methods with unused parameters can be a symptom of an unfinished refactoring or a bug.