Actions: Remove 96px, 128px action icons #530
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are very incomplete, and most of the ones
that exist are non up to date with the other sizes.
Action icons are generally used at 16-24px.
Rarely at 32px and even moreso at 48px.
Upstream removed 64px and above long ago.
But we'll keep 64px for now since there may be
cases where some DEs haven't implemented proper
HiDPI scaling, and may need the 48px and 64px
icons when 24px and 32px icons are doubled.
Removed some symlinks that turned out to be
not used or needed along the way:
- `messagebox_*` - Don't seem to be used anywhere
anymore, possibly old KDE3 icons
- `setroubleshoot_icon` - Fedora's setroubleshoot app has its own
newer/nicer icons (including scalable and
symbolic), ours doesn't match design anyway
- `stock_view-details` - Old Gtk2 icon, only can find use in Evolution
at 16px and they provide a better icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sizes are very incomplete, and most of the ones
that exist are non up to date with the other sizes.
Action icons are generally used at 16-24px.
Rarely at 32px and even moreso at 48px.
Upstream removed 64px and above long ago.
But we'll keep 64px for now since there may be
cases where some DEs haven't implemented proper
HiDPI scaling, and may need the 48px and 64px
icons when 24px and 32px icons are doubled.
Removed some symlinks that turned out to be
not used or needed along the way:
messagebox_*- Don't seem to be used anywhere anymore, possibly old KDE3 iconssetroubleshoot_icon- Fedora's setroubleshoot app has its own newer/nicer icons (including scalable and symbolic), ours doesn't match design anywaystock_view-details- Old Gtk2 icon, only can find use in Evolution at 16px and they provide a better icon