Skip to content

fix: properly join publicPath, basePath #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2021
Merged

fix: properly join publicPath, basePath #277

merged 2 commits into from
Oct 9, 2021

Conversation

MoyuScript
Copy link
Contributor

@MoyuScript MoyuScript commented Sep 25, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

When output.publicPath is not ends with /, the path of output will be incorrect.

Webpack configuration:

output: {
   publicPath: '/public/js'
 },

Wrong output:

{
  "index.js": "/public/jsindex.04565a72d083184c3c5a.js"
}

Correct output:

{
  "index.js": "/public/js/index.04565a72d083184c3c5a.js"
}

@shellscape shellscape changed the title Fix bugs when join publicPath without slash appended fix: properly join publicPath, basePath Sep 26, 2021
@shellscape
Copy link
Owner

Thanks for the PR. Looks like you have a few failing tests to address before we can accept it.

@shellscape shellscape merged commit 721f4a5 into shellscape:master Oct 9, 2021
@shellscape
Copy link
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants