main: Autocomplete deprioritize own name #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shazow
requested changes
Jul 24, 2020
chat/room.go
Outdated
| @@ -235,6 +235,14 @@ func (r *Room) NamesPrefix(prefix string) []string { | |||
| users = append(users, item.Value().(*Member).User) | |||
| } | |||
| sort.Sort(message.RecentActiveUsers(users)) | |||
| for i, user := range users { | |||
There was a problem hiding this comment.
Is it necessary to change the signature of a public method and break API compatibility?
Can we put this in completeName instead?
host.go
Outdated
| @@ -243,8 +243,8 @@ func (h *Host) Serve() { | |||
| h.listener.Serve() | |||
| } | |||
|
|
|||
| func (h *Host) completeName(partial string) string { | |||
| names := h.NamesPrefix(partial) | |||
| func (h *Host) completeName(partial string, current_user *message.User) string { | |||
There was a problem hiding this comment.
Go uses camelCase instead of snake_case for variables.
Suggested change
| func (h *Host) completeName(partial string, current_user *message.User) string { | |
| func (h *Host) completeName(partial string, currentUser *message.User) string { |
shazow
changed the title
|
One more request if possible: Would you mind fixing Line 261 in 3b8e644 user.joined if user.lastMsg is zero-value?
|
|
pavelz
force-pushed
the
my_name_last_autocomplete
branch
from
2f0bf90 to
14db2dd
Compare
shazow
requested changes
Jul 28, 2020
host.go
Outdated
| names := h.NamesPrefix(partial) | ||
| if len(names) == 0 { | ||
| // Didn't find anything | ||
| return "" | ||
| } | ||
|
|
||
| for i, user := range names { |
There was a problem hiding this comment.
Do we actually need a loop here, and a full array copy inside of it? We're just returning one name, could we check if the name we're returning is currentUser and if it is then return the one before that?
Also, then we don't need to pass in a currentUser *message.User, we could just pass in skipName string instead.
There was a problem hiding this comment.
thats sounds reasonable,yes.
pavelz
force-pushed
the
my_name_last_autocomplete
branch
from
14db2dd to
f8b3ce8
Compare
shazow
reviewed
Jul 28, 2020
host.go
Outdated
| names := h.NamesPrefix(partial) | ||
| if len(names) == 0 { | ||
| // Didn't find anything | ||
| return "" | ||
| } | ||
|
|
||
| for _, userName := range names { |
There was a problem hiding this comment.
Why do we need a loop? Why not just check the name we're going to return?
shazow
requested changes
Jul 28, 2020
host.go
Outdated
Comment on lines
246
to
259
| func (h *Host) completeName(partial string, skipName string) string { | ||
| names := h.NamesPrefix(partial) | ||
| if len(names) == 0 { | ||
| // Didn't find anything | ||
| return "" | ||
| } | ||
|
|
||
| for _, userName := range names { | ||
| if userName != skipName { | ||
| return userName | ||
| } | ||
| } | ||
|
|
||
| return names[len(names)-1] | ||
| } |
There was a problem hiding this comment.
Suggested change
| func (h *Host) completeName(partial string, skipName string) string { | |
| names := h.NamesPrefix(partial) | |
| if len(names) == 0 { | |
| // Didn't find anything | |
| return "" | |
| } | |
| for _, userName := range names { | |
| if userName != skipName { | |
| return userName | |
| } | |
| } | |
| return names[len(names)-1] | |
| } | |
| func (h *Host) completeName(partial string, skipName string) string { | |
| names := h.NamesPrefix(partial) | |
| if len(names) == 0 { | |
| // Didn't find anything | |
| return "" | |
| } else if name := names[0]; name != skipName { | |
| // First name is not the skipName, great | |
| return name | |
| } else if len(names) > 1 { | |
| // Next candidate | |
| return names[1] | |
| } | |
| return "" | |
| } |
pavelz
force-pushed
the
my_name_last_autocomplete
branch
from
f8b3ce8 to
284fde4
Compare
* addded condition for zero time on lastMsg. * removed extra paramter in NamePrefix * moved code from NamePrefix to completeName * removed extra parameter in tests calling to NamePrefix
pavelz
force-pushed
the
my_name_last_autocomplete
branch
from
284fde4 to
5885f7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current user is moved to the last item on the name lookup list.
Fixes #314.