Fix syntax highlighting for bash/zsh #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith-hall
reviewed
Apr 12, 2025
There was a problem hiding this comment.
Looks good, thanks. I have the idea that the changelog entry could be a bit misleading though - we haven't changed any syntax highlighting grammars, just applied some mappings to ensure the correct grammar is used by default. What do you think of my reworded suggestion?
|
Sounds great! |
Co-authored-by: Keith Hall <[email protected]>
keith-hall
approved these changes
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3231, fixes #3145.
Any files named (or with the extensions):
Will now be correctly highlighted.
Based off of the recommendation of this comment, but let me know if there's a better way to go about this.