Skip to content

WIP. Sync with Git Repositories #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 52 commits into from
Closed

WIP. Sync with Git Repositories #813

wants to merge 52 commits into from

Conversation

knyhle
Copy link
Contributor

@knyhle knyhle commented Mar 31, 2019 •
edited by issuehunt-oss bot
Loading

Short description of what this resolves:

Adding git sync. WIP. Requesting review.

  • 1. It should ask either backup needs to be saved on Github Gist or simple Git Repository.
  • 2. Once the User select the Git Repo, it should setup accordingly.
  • 3. Provide user option to either use Github or GitLab and create a repository from there by their profile tokens.
    • Create Repository on Github
    • Create Repository on GitLab
  • 4. By Download means, user can do git pull forcefully.
  • 5. By Upload means, user can do git push forcefully.
  • 6. Allow user to setup branches or profiles like master and office and keep the selected profile / branch in Sync Global Settings and download/ upload to that branch.
  • 7. When user is switched to Gist, it should not upload the Git folder there.
  • 8. Support Github and Gitlab Enterprise versions

At the moment creating / pushing to different branches on github works.
Haven't wrote the gitlab service.
Will need to rework regex for enterprise versions probably.

Changes proposed in this pull request:

  • WIP.

Fixes: #413

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • I have read the contribution guidelines.
  • My change requires a change to the documentation and GitHub Wiki.
  • I have updated the documentation and Wiki accordingly.
IssueHunt Summary

IssueHunt has been backed by the following sponsors. Become a sponsor

knyhle added 22 commits March 27, 2019 00:06
@knyhle
fix bug in ignoreUploadFolder
500de60
@knyhle
prettify custom setting json
3056d18
@knyhle
write ext file to user folder
44999fa
@knyhle
handle no git error
2229a80
@knyhle
add simplegit dependency
c5a3adf
@knyhle
add sync mode to settings
72c2b7b
@knyhle
add basic git service file
bb539ce
@knyhle
init git
2ffc886
@knyhle
add files to repo
9c5d14d
@knyhle
add git repoUrl to setting
7e2ea9d
@knyhle
add getRepoUrl function
599d9a4
@knyhle
add parsing service
e910dd4
@knyhle
add github and gitlab service token variables to custom settings
0729ece
@knyhle
add service information for github and gitlab to gitservices
6ed4ea7
@knyhle
rewrite inputbox for multiple services - github or gitlab
45d1ba6
@knyhle
rewrite init for uploading with git
faa12b9
@knyhle
move github auth into async function call
0da2449
@knyhle
change parse service to parse service or reponame
6c678e6
@knyhle
add remote to git init
43f6616
@knyhle
rename parse service to parse url to make it more clear what the func…
9fd6d98 
…tion is doing
@knyhle
add bad auth error checking in commons
37c6fba
@knyhle
add and make git repo on github
bc73082
@shanalikhan shanalikhan changed the base branch from master to v3.2.8 March 31, 2019 21:02
knyhle added 4 commits April 2, 2019 01:06
@knyhle
update documentation for gitservice
7d97697
@knyhle
move update extensions to plugin service
c184976
@knyhle
remove unnecessary variables in download/upload init
9ec52c5
@knyhle
rework regex to capture protocol given
c846ac7 
However, still only use https when pushing as token pushing does NOT!!
work with ssh. While we could add a ssh check and support it
eventually in the future, https works right and it's deemed low
priority.

Thus, even if the url specifies ssh, we'll update through https
shanalikhan
shanalikhan requested changes Apr 2, 2019
View reviewed changes
Copy link
Owner

@shanalikhan shanalikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed message sent on slack.

knyhle added 4 commits April 2, 2019 19:00
@knyhle
add github check during init settings -- preapre for gitlab
5c05502 
rename localsettings -> localconfig to make it even with update
@knyhle
convert ssh url to https
800cca7 
like with push, ssh also does not work with pull / resetting
@knyhle
move gist settings to its own settings class
351fb6b
@knyhle
move git settings to its own settings class
c1b904b 
add option picker for changing branches and setting force push / pull
@shanalikhan shanalikhan changed the base branch from v3.2.8 to v3.2.9 April 16, 2019 08:46
@gudvinr
Copy link

gudvinr commented Apr 23, 2019

Why do you need to access Github/Gitlab API directly? Wouldn't it be a lot more convenient to use just plain git interface using git clone/pull/push/fetch/etc?

Since you're heavily tying your implementation to limited number of services it won't allow it to use with your private Git repos (self-hosted or just local) and it requires internet access to use synchronisation.

It doesn't solve issue in the way it was meant to be implemented.

@shanalikhan shanalikhan changed the base branch from v3.2.9 to v3.3.0 April 24, 2019 10:09
@jordyvandomselaar
Copy link

I'm really excited about a feature like this, I really don't want my settings on a gist that can be found by anyone as it contains sensitive information.

@totkeks
Copy link

totkeks commented Jun 4, 2019

I'm really excited about a feature like this, I really don't want my settings on a gist that can be found by anyone as it contains sensitive information.

The gists have always been private by default. Also your user's local vscode settings (settings.json) do not contain sensitive information by default.

@lizhuangs
Copy link

I'm really excited about a feature like this, I really don't want my settings on a gist that can be found by anyone as it contains sensitive information.

The gists have always been private by default. Also your user's local vscode settings (settings.json) do not contain sensitive information by default.

The gists have always been private by default.,however It can be seen by anyone who get the gist url.It is unsafe.

@shanalikhan shanalikhan changed the base branch from v3.3.0 to v3.4.0 June 25, 2019 14:27
@jifalops
Copy link

Will this still require github access or will it also accept ssh urls like [email protected]/user/repo?

@shanalikhan
Copy link
Owner

Let me know if you want to work on it. I will reopen this PR

@shanalikhan shanalikhan closed this Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanalikhan shanalikhan shanalikhan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@knyhle @gudvinr @jordyvandomselaar @totkeks @lizhuangs @jifalops @shanalikhan