Change precedence for CPLN_ORG_UPSTREAM env var in copy-image-from-upstream command
#137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelgomesxyz
force-pushed
the
copy-image-from-upstream-starts-with-fix
branch
from
8793caa to
d1fd881
Compare
rafaelgomesxyz
force-pushed
the
copy-image-from-upstream-org-precedence
branch
from
1d03eac to
329808a
Compare
Base automatically changed from
copy-image-from-upstream-starts-with-fix
to
main
January 22, 2024 04:15
|
@rafaelgomesxyz double-check my merge commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: On top of #136
Environment variables should take precedence over the
controlplane.ymlfile. This is currently not true for theCPLN_ORG_UPSTREAMenv var in thecopy-image-from-upstreamcommand.This PR changes that.