Skip to content

perf(net): Avoid parsing headers twice #8618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented May 20, 2025

No description provided.

@avelad avelad requested review from TAhub and tykus160 May 20, 2025 10:32
@avelad avelad added type: performance A performance issue component: networking The issue involves the networking system of Shaka Player priority: P2 Smaller impact or easy workaround labels May 20, 2025
@avelad avelad added this to the v4.15 milestone May 20, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@avelad avelad merged commit cd9c850 into shaka-project:main May 20, 2025
14 of 16 checks passed
@avelad avelad deleted the fetch-headers branch May 20, 2025 11:57
avelad added a commit that referenced this pull request May 22, 2025
avelad added a commit that referenced this pull request May 22, 2025
@francoism90
Copy link
Contributor

Any benchmarks or numbers?

This looks interesting! :)

avelad pushed a commit that referenced this pull request Jun 6, 2025
avelad pushed a commit that referenced this pull request Jun 9, 2025
avelad pushed a commit that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: networking The issue involves the networking system of Shaka Player priority: P2 Smaller impact or easy workaround type: performance A performance issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants