Skip to content

feat: Add canupdatestarttime to allow update the startTime safely #8604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

feat: Add canupdatestarttime to allow update the startTime safely #8604

merged 1 commit into from
May 14, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented May 13, 2025

Close #8506

Example of use:

this.player_.addEventListener('canupdatestarttime', () => {
  this.player_.updateStartTime(this.player_.seekRange().start + 300);
});

@avelad avelad added type: enhancement New feature or request priority: P2 Smaller impact or easy workaround labels May 13, 2025
@avelad avelad added this to the v4.15 milestone May 13, 2025
@avelad avelad mentioned this pull request May 13, 2025
Closed
@avelad avelad requested review from joeyparrish, TAhub and tykus160 May 13, 2025 13:53
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit e4fcc94 into shaka-project:main May 14, 2025
45 of 51 checks passed
@avelad avelad deleted the canupdatestarttime branch May 14, 2025 07:59
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 13, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@TAhub TAhub Awaiting requested review from TAhub

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.15
Development

Successfully merging this pull request may close these issues.

Seek not performed on live stream right after load is finished
3 participants
@avelad @shaka-bot @joeyparrish