Skip to content

fix(UI): Make UI display 4096x2160 (DCI 4k) video as also being "4k" #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

fix(UI): Make UI display 4096x2160 (DCI 4k) video as also being "4k" #8359

merged 1 commit into from
Mar 31, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 31, 2025

Fixes #8357

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Mar 31, 2025
@avelad avelad added this to the v4.15 milestone Mar 31, 2025
theodab
theodab reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I should change the title to be more terse though.

@theodab theodab changed the title fix(UI): UI shows nonsensical resolution options for 4096x2160 (DCI 4k) video fix(UI): Make UI display 4096x2160 (DCI 4k) video as also being "4k" Mar 31, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 00ae291 into shaka-project:main Mar 31, 2025
35 of 38 checks passed
@shaka-bot shaka-bot mentioned this pull request Mar 31, 2025
Merged
@avelad avelad deleted the ui-4k branch March 31, 2025 09:46
avelad added a commit that referenced this pull request Mar 31, 2025
@avelad
fix(UI): Make UI display 4096x2160 (DCI 4k) video as also being "4k" (#…
f737ca0 
…8359)

Fixes #8357
@shaka-bot shaka-bot mentioned this pull request Mar 31, 2025
Merged
avelad added a commit that referenced this pull request Mar 31, 2025
@avelad
fix(UI): Make UI display 4096x2160 (DCI 4k) video as also being "4k" (#…
cf78c1c 
…8359)

Fixes #8357
@shaka-bot shaka-bot mentioned this pull request Mar 31, 2025
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 30, 2025
@shaka-project shaka-project locked as resolved and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@tykus160 tykus160 Awaiting requested review from tykus160

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.15
Development

Successfully merging this pull request may close these issues.

Player shows nonsensical resolution options for 4096x2160 (DCI 4k) video
3 participants
@avelad @shaka-bot @theodab