fix: External text tracks in src mode related issues #8527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All changes were part of shaka-project#8520
avelad
reviewed
Apr 29, 2025
lib/player.js
Outdated
| const trackElement = | ||
| /** @type {!HTMLTrackElement} */(document.createElement('track')); | ||
| const trackElement = /** @type {!HTMLTrackElement} */ | ||
| (this.video_.ownerDocument.createElement('track')); |
There was a problem hiding this comment.
Please see: #8520 (comment)
There was a problem hiding this comment.
@avelad
This change has been reverted
avelad
added
type: bug
|
Incremental code coverage: 97.44% |
avelad
approved these changes
Apr 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes were part of #8520
addSrcTrackElement_()are now released correctlyHTMLTrackElement.trackto access its associatedTextTrack. Searching inHTMLMediaElement.textTracksis not reliable<source>elements during initialization. User added<track>elements are not harmful and they may want to keep them for dual subtitles for example.