-
Notifications
You must be signed in to change notification settings - Fork 17
vcc glsl backend upgrades #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JuanDiegoMontoya
wants to merge
8
commits into
shady-gang:master
Choose a base branch
from
JuanDiegoMontoya:fix-glsl-bug
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we get this downgraded to a draft PR? I don't have permission to change it. |
Hugobros3
reviewed
May 7, 2024
Hugobros3
reviewed
May 7, 2024
Hugobros3
reviewed
May 10, 2024
Could I interest you in picking this back up, perhaps adding some extra testing infrastructure so that we can guard against future regression ? |
I'll see if I can take a look at re-syncing with main later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
layout(binding = n)
for storage and uniform blocks with descriptor binding annotation.layout(location = n)
for uniform constants, input variables, and output variables with location annotation.#version
directive (e.g. using an SSBO will require at least version 430).extern
to declare these)Expanded support for samplers and images are left for a future PR.